[webkit-reviews] review granted: [Bug 221543] [SOUP] Simplify ResourceRequest and ResourceResponse : [Attachment 419573] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 221543: [SOUP] Simplify ResourceRequest and ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=221543

Attachment 419573: Patch

https://bugs.webkit.org/attachment.cgi?id=419573&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 419573
  --> https://bugs.webkit.org/attachment.cgi?id=419573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419573&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:63
> +    GRefPtr<SoupMessage> soupMessage =
adoptGRef(soup_message_new_from_uri(httpMethod().ascii().data(), uri.get()));

I would have used “auto” here because the “adoptGRef()” +
“soup_message_new_foo()”
calls already make it quite clear that the inferred type will be
“GRefPtr<SoupMessage>”
No strong preference, though.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:-174
> -

Nice to see some code go away \o/