[webkit-reviews] review granted: [Bug 221512] Check that CGPDFDocumentRef is consistently unlocked and printable : [Attachment 419489] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 7 19:44:10 PST 2021


Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 221512: Check that CGPDFDocumentRef is consistently unlocked and printable
https://bugs.webkit.org/show_bug.cgi?id=221512

Attachment 419489: Patch v1

https://bugs.webkit.org/attachment.cgi?id=419489&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 419489
  --> https://bugs.webkit.org/attachment.cgi?id=419489
Patch v1

Looks good. I think there is testing infra for password PDFs. I don't remember
if it covered printing code path. Consider taking a look and writing a test.
This is not required.


More information about the webkit-reviews mailing list