[webkit-reviews] review granted: [Bug 221532] [macOS] Return key binding for date inputs conflicts with return to submit form : [Attachment 419544] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 221532: [macOS] Return key binding for date inputs conflicts with return to
submit form
https://bugs.webkit.org/show_bug.cgi?id=221532

Attachment 419544: Patch

https://bugs.webkit.org/attachment.cgi?id=419544&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 419544
  --> https://bugs.webkit.org/attachment.cgi?id=419544
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419544&action=review

> Source/WebCore/html/BaseDateAndTimeInputType.cpp:421
> +    int charCode = event.charCode();

Nit - I'm not sure the local variable adds much here. Maybe just check
(event.charCode() == '\r') below?