[webkit-reviews] review granted: [Bug 221521] WebCore::genericFamily() should use static_cf_cast<> : [Attachment 419512] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 7 10:05:41 PST 2021


Sam Weinig <sam at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 221521: WebCore::genericFamily() should use static_cf_cast<>
https://bugs.webkit.org/show_bug.cgi?id=221521

Attachment 419512: Patch v1

https://bugs.webkit.org/attachment.cgi?id=419512&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 419512
  --> https://bugs.webkit.org/attachment.cgi?id=419512
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=419512&action=review

> Source/WebCore/ChangeLog:10
> +	   - Switch from dynamic_cf_cast<> to static_cf_cast<> because we

Looks like you actually use checked_cf_cast. Probably want to update the
ChangeLog comment and title.


More information about the webkit-reviews mailing list