[webkit-reviews] review granted: [Bug 221497] SetIntegrityLevel should call [[DefineOwnProperty]] with partial descriptor : [Attachment 419496] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 221497: SetIntegrityLevel should call [[DefineOwnProperty]] with partial
descriptor
https://bugs.webkit.org/show_bug.cgi?id=221497

Attachment 419496: Patch

https://bugs.webkit.org/attachment.cgi?id=419496&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 419496
  --> https://bugs.webkit.org/attachment.cgi?id=419496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419496&action=review

r=me

> JSTests/stress/freeze-invokes-out-of-memory.js:17
> +    Object.defineProperty(arguments, '0', {value: s});

1. Can you rename this filename to define-property-invokes-out-of-memory.js?
2. Can we have a test using freeze onto arguments and ensures OOM is not
happening?