[webkit-reviews] review granted: [Bug 221502] [LFC][IFC] Continuation pre and post block inline boxes should not have both the start and end decorations of the original inline box : [Attachment 419467] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 221502: [LFC][IFC] Continuation pre and post block inline boxes should not
have both the start and end decorations of the original inline box
https://bugs.webkit.org/show_bug.cgi?id=221502

Attachment 419467: Patch

https://bugs.webkit.org/attachment.cgi?id=419467&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 419467
  --> https://bugs.webkit.org/attachment.cgi?id=419467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419467&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:88
> +	       if (!childRenderer.parent()->isAnonymousBlock())
> +		   return
makeUnique<Layout::ContainerBox>(Layout::Box::ElementAttributes {
Layout::Box::ElementType::GenericElement }, WTFMove(style));

I'd just revert the condition and use the makeUnique at the end in all cases.