[webkit-reviews] review granted: [Bug 220768] Update LayoutTests/imported/w3c/web-platform-tests/shadow-dom to the latest : [Attachment 419424] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 5 21:26:58 PST 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Tetsuharu Ohzeki [UTC+9]
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 220768: Update LayoutTests/imported/w3c/web-platform-tests/shadow-dom to
the latest
https://bugs.webkit.org/show_bug.cgi?id=220768

Attachment 419424: Patch

https://bugs.webkit.org/attachment.cgi?id=419424&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 419424
  --> https://bugs.webkit.org/attachment.cgi?id=419424
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419424&action=review

>
LayoutTests/imported/w3c/web-platform-tests/shadow-dom/nested-slot-remove-crash
-expected.txt:1
> +CONSOLE MESSAGE: SyntaxError: Cannot declare a const variable twice: 'root'.

Huh, we should fix this test upstream!

>
LayoutTests/imported/w3c/web-platform-tests/shadow-dom/nested-slot-remove-crash
.html:30
> +  const root = host.attachShadow({mode:"open"});

This is clearly wrong.


More information about the webkit-reviews mailing list