[webkit-reviews] review granted: [Bug 221501] REGRESSION (r271815): [macOS] /dev/dtracehelper is blocked on customer builds, even with SIP disabled : [Attachment 419460] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 221501: REGRESSION (r271815): [macOS] /dev/dtracehelper is blocked on
customer builds, even with SIP disabled
https://bugs.webkit.org/show_bug.cgi?id=221501

Attachment 419460: Patch

https://bugs.webkit.org/attachment.cgi?id=419460&action=review




--- Comment #3 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 419460
  --> https://bugs.webkit.org/attachment.cgi?id=419460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419460&action=review

Great! R=me.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:710
> +    dispatch_once(&onceToken, ^{
> +	   isSIPDisabled = !csr_check(CSR_DISABLE_FLAGS);

Since this only seems to be called on the main thread, I think the
dispatch_once is not needed.