[webkit-reviews] review granted: [Bug 221429] Allow Password AutoFill in more text field configurations : [Attachment 419433] Second try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 5 10:52:46 PST 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 221429: Allow Password AutoFill in more text field configurations
https://bugs.webkit.org/show_bug.cgi?id=221429

Attachment 419433: Second try

https://bugs.webkit.org/attachment.cgi?id=419433&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 419433
  --> https://bugs.webkit.org/attachment.cgi?id=419433
Second try

View in context: https://bugs.webkit.org/attachment.cgi?id=419433&action=review

r=mews

> Source/WebCore/editing/cocoa/AutofillElements.cpp:78
>      : m_username(username)
>      , m_password(password)
> +    , m_secondPassword(secondPassword)

(Not exactly new to this patch, but these could all be `WTFMove`d into the
class members)


More information about the webkit-reviews mailing list