[webkit-reviews] review granted: [Bug 221455] Move AudioHardwareListener into the GPU Process : [Attachment 419373] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 221455: Move AudioHardwareListener into the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=221455

Attachment 419373: Patch

https://bugs.webkit.org/attachment.cgi?id=419373&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 419373
  --> https://bugs.webkit.org/attachment.cgi?id=419373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419373&action=review

We will have to reestablish the connection when the GPU process crashes.

> Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.h:43
> +class RemoteAudioHardwareListenerProxy : private
WebCore::AudioHardwareListener::Client {

Nit: final

> Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.h:52
> +    void audioHardwareDidBecomeActive() override;
> +    void audioHardwareDidBecomeInactive() override;

Ditto.