[webkit-reviews] review granted: [Bug 221476] [ews] commit-queue should use commits.webkit.org url instead of trac url : [Attachment 419417] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 5 10:10:12 PST 2021


Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 221476: [ews] commit-queue should use commits.webkit.org url instead of
trac url
https://bugs.webkit.org/show_bug.cgi?id=221476

Attachment 419417: Patch

https://bugs.webkit.org/attachment.cgi?id=419417&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 419417
  --> https://bugs.webkit.org/attachment.cgi?id=419417
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419417&action=review

> Tools/CISupport/ews-build/steps.py:3109
> +	   return 'https://commits.webkit.org/r{}'.format(revision)

I think we should use identifiers here, but this is good step in the right
direction, so I'm going to r+ it.


More information about the webkit-reviews mailing list