[webkit-reviews] review granted: [Bug 221453] Make sure click attribution is processed in case of redirected kept alive loads : [Attachment 419368] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 221453: Make sure click attribution is processed in case of redirected kept
alive loads
https://bugs.webkit.org/show_bug.cgi?id=221453

Attachment 419368: Patch

https://bugs.webkit.org/attachment.cgi?id=419368&action=review




--- Comment #4 from John Wilander <wilander at apple.com> ---
Comment on attachment 419368
  --> https://bugs.webkit.org/attachment.cgi?id=419368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419368&action=review

Thanks for fixing this!

>
LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-f
etch-keepalive-expected.txt:2
> +CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by
Access-Control-Allow-Origin.

Could we add a header to the php file to silence this output?

>
LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-f
etch-keepalive-expected.txt:3
> +CONSOLE MESSAGE: Fetch API cannot load
https://127.0.0.1:8443/.well-known/private-click-measurement/trigger-attributio
n/whatever due to access control checks.

Ditto.

>
LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-f
etch-keepalive.html:36
> +	       triggerFetch(12);

Do we risk being flaky because of this time dependence?

>
LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-f
etch-keepalive.html:42
> +	       // Do an invalid private click attribution fetch to ensure the
previous correct click attribution fetch will be finished.

Clever.