[webkit-reviews] review granted: [Bug 221228] Web Inspector: Implement backend support for maintaining a list of Grid layout contexts : [Attachment 419315] Patch v1.1 - Review Notes

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 221228: Web Inspector: Implement backend support for maintaining a list of
Grid layout contexts
https://bugs.webkit.org/show_bug.cgi?id=221228

Attachment 419315: Patch v1.1 - Review Notes

https://bugs.webkit.org/attachment.cgi?id=419315&action=review




--- Comment #6 from BJ Burg <bburg at apple.com> ---
Comment on attachment 419315
  --> https://bugs.webkit.org/attachment.cgi?id=419315
Patch v1.1 - Review Notes

View in context: https://bugs.webkit.org/attachment.cgi?id=419315&action=review

r=me

> LayoutTests/inspector/dom/nodeLayoutContextTypeChanged.html:51
> +		  
InspectorTest.evaluateInPage(`document.getElementById("nonGridToGrid").style.di
splay = "grid"`),

Personally, I like to put these triggers into their own named local function
for clarity. e.g., changeStyleToDisplayGrid() => ...

> LayoutTests/inspector/dom/nodeLayoutContextTypeChanged.html:58
> +    WI.domManager.requestDocument((node) => {

Nit: requestDocument now returns a promise if no callback. So this could be
WI.domManager.requestDocument().then((doc) => ...)