[webkit-reviews] review denied: [Bug 221224] [WPE][GTK] BubblewrapLauncher should create flatpak-info keyfile only once : [Attachment 418918] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 221224: [WPE][GTK] BubblewrapLauncher should create flatpak-info keyfile
only once
https://bugs.webkit.org/show_bug.cgi?id=221224

Attachment 418918: Patch

https://bugs.webkit.org/attachment.cgi?id=418918&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 418918
  --> https://bugs.webkit.org/attachment.cgi?id=418918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418918&action=review

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:697
> +    static GUniquePtr<char> data;

Shouldn't this be better be NeverDestroyed<CString> instead?
Or even MainThreadNeverDestroyed<CString> ;-)