[webkit-reviews] review granted: [Bug 221423] Potential crash under BaseAudioContext's toJSNewlyCreated() : [Attachment 419308] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 12:07:53 PST 2021


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 221423: Potential crash under BaseAudioContext's toJSNewlyCreated()
https://bugs.webkit.org/show_bug.cgi?id=221423

Attachment 419308: Patch

https://bugs.webkit.org/attachment.cgi?id=419308&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 419308
  --> https://bugs.webkit.org/attachment.cgi?id=419308
Patch

Is there some simpler pattern that is less specific to the design of the
classes that can be used to test the "correct wrapper" consistently? I remember
when we (I?) did this for a lot of DOM classes with the
fast/dom/wrapper-classes.html test, but it seems that was ended up being
specific to the DOM than to wrapping in general.


More information about the webkit-reviews mailing list