[webkit-reviews] review denied: [Bug 221372] Link libnetworkextension at compile time : [Attachment 419282] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied katherine_cheney at apple.com's
request for review:
Bug 221372: Link libnetworkextension at compile time
https://bugs.webkit.org/show_bug.cgi?id=221372

Attachment 419282: Patch

https://bugs.webkit.org/attachment.cgi?id=419282&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 419282
  --> https://bugs.webkit.org/attachment.cgi?id=419282
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419282&action=review

This is almost correct, but I think it will break Base System in its current
form.

> Source/WebKit/Configurations/WebKit.xcconfig:137
> +WK_LIBNETWORKEXTENSION_LDFLAGS_macosx = -lnetworkextension;

In Bug 218314 (r269173) we used "WK_NETWORK_EXTENSION_LD_FLAGS_macosx =
-weak_framework NetworkExtension;" because this library is not present in the
Base System (recovery mode). I think we need to do the same here.