[webkit-reviews] review granted: [Bug 221296] SpeechRecognitionPermissionManager should not handle requests that are already cancelled : [Attachment 419239] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 221296: SpeechRecognitionPermissionManager should not handle requests that
are already cancelled
https://bugs.webkit.org/show_bug.cgi?id=221296

Attachment 419239: Patch

https://bugs.webkit.org/attachment.cgi?id=419239&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 419239
  --> https://bugs.webkit.org/attachment.cgi?id=419239
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419239&action=review

> Source/WebKit/UIProcess/SpeechRecognitionPermissionManager.cpp:227
> +    auto clientOrigin = recognitionRequest->clientOrigin();

Maybe pass recognitionRequest as a parameter to  requestUserPermission.
That will remove the need for the assert.