[webkit-reviews] review granted: [Bug 221384] REGRESSION(r267763) Network process launches earlier than before : [Attachment 419242] patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 221384: REGRESSION(r267763) Network process launches earlier than before
https://bugs.webkit.org/show_bug.cgi?id=221384

Attachment 419242: patch

https://bugs.webkit.org/attachment.cgi?id=419242&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 419242
  --> https://bugs.webkit.org/attachment.cgi?id=419242
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419242&action=review

r=me with a comment.

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:590
> +    if (!m_networkProcess)

I am not convinced about this particular part of the change. This gets called
when the WebProcess finishes launching. I believe we usually have a network
process by this point but if we don't, I am not convinced returning early is
the right thing to do here. It means we wouldn't send the XPCEndpoint to the
process. What makes sure we send the XPC endpoint to the process when the
network process actually launches?

I cannot find such logic. Note that there may be a pre-existing bug here when
the network process relaunches due to a crash. I am not quite sure what is
XPCEndpoint is used for, so maybe it's not a big deal.