[webkit-reviews] review granted: [Bug 221328] Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode aware : [Attachment 419128] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 221328: Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode
aware
https://bugs.webkit.org/show_bug.cgi?id=221328

Attachment 419128: Patch

https://bugs.webkit.org/attachment.cgi?id=419128&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 419128
  --> https://bugs.webkit.org/attachment.cgi?id=419128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419128&action=review

r=me, with a nit comment inline.

> Source/WebCore/rendering/RenderBox.cpp:5100
> +    if (style().width().isAuto() && style().height().isAuto() &&
!style().logicalTop().isAuto() && !style().logicalBottom().isAuto() &&
(style().logicalLeft().isAuto() || style().logicalRight().isAuto()))

What about logicalWidth() instead of width()? I guess it doesn't really matter
as we have an and for width and height, but maybe it'd be worth changing for
consistency dunno.