[webkit-reviews] review granted: [Bug 221357] Avoid an ancestor walk in HTMLFormControlElement::computeWillValidate() : [Attachment 419212] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 221357: Avoid an ancestor walk in
HTMLFormControlElement::computeWillValidate()
https://bugs.webkit.org/show_bug.cgi?id=221357

Attachment 419212: Patch

https://bugs.webkit.org/attachment.cgi?id=419212&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 419212
  --> https://bugs.webkit.org/attachment.cgi?id=419212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419212&action=review

> Source/WebCore/ChangeLog:13
> +	   * dom/Document.h:
> +	   (WebCore::Document::addDisabledFieldsetElement):

Update these change log entries?

> Source/WebCore/html/HTMLDataListElement.cpp:64
> +    if (insertionType.treeScopeChanged)
> +	   treeScope().incrementDataListElementCount();

We can do this before calling HTMLElement::insertedIntoAncestor.

> Source/WebCore/page/PointerLockController.cpp:106
> -void PointerLockController::elementRemoved(Element& element)
> +void PointerLockController::elementWasRemoved(Element& element)

Or maybe didRemoveElement?