[webkit-reviews] review granted: [Bug 221362] Allow highlight delegate to be set on WKWebView : [Attachment 419204] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 3 18:11:16 PST 2021

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 221362: Allow highlight delegate to be set on WKWebView

Attachment 419204: Patch


--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 419204
  --> https://bugs.webkit.org/attachment.cgi?id=419204

View in context: https://bugs.webkit.org/attachment.cgi?id=419204&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1417
> +#endif

#else! two returns in a row is bizarre

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:368
> + at property (nonatomic, weak, setter=_setAppHighlightsDelegate:) id
<_WKAppHighlightDelegate> _appHighlightsDelegate

is it highlight or highlights? Please decide, now you've got both in one line
(and this seems like the opportunity to fix the property name).

More information about the webkit-reviews mailing list