[webkit-reviews] review granted: [Bug 221362] Allow highlight delegate to be set on WKWebView : [Attachment 419204] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 221362: Allow highlight delegate to be set on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=221362

Attachment 419204: Patch

https://bugs.webkit.org/attachment.cgi?id=419204&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 419204
  --> https://bugs.webkit.org/attachment.cgi?id=419204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419204&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1417
> +#endif

#else! two returns in a row is bizarre

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:368
> + at property (nonatomic, weak, setter=_setAppHighlightsDelegate:) id
<_WKAppHighlightDelegate> _appHighlightsDelegate
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

is it highlight or highlights? Please decide, now you've got both in one line
(and this seems like the opportunity to fix the property name).