[webkit-reviews] review granted: [Bug 221236] Introduce ImageExtractionContentContainer and add UA shadow root support for image extraction : [Attachment 419090] WIP

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 221236: Introduce ImageExtractionContentContainer and add UA shadow root
support for image extraction
https://bugs.webkit.org/show_bug.cgi?id=221236

Attachment 419090: WIP

https://bugs.webkit.org/attachment.cgi?id=419090&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 419090
  --> https://bugs.webkit.org/attachment.cgi?id=419090
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=419090&action=review

r=me

> Source/WebCore/html/shadow/ImageExtractionContentContainer.cpp:41
> +class RenderImageExtractionContentContainer : public RenderBlockFlow {

should the entire class be `final`?

> Source/WebCore/html/shadow/ImageExtractionContentContainer.h:35
> +class HTMLDivElement;

NIT: you've already `#include` this so no need to forward declare again :P

> Source/WebCore/html/shadow/ImageExtractionContentContainer.h:39
> +class ImageExtractionContentContainer : public HTMLDivElement {

should the entire class be `final`?

> Source/WebCore/rendering/RenderImage.cpp:839
> +	   LayoutStateMaintainer statePusher(*this, locationOffset(),
hasTransform() || hasReflection() || style().isFlippedBlocksWritingMode());

does this need to be hoisted outside the `for` so that it also covers
`clearChildNeedsLayout()` like before?