[webkit-reviews] review granted: [Bug 221280] [build.webkit.org] Update dashboard links for layout test results : [Attachment 419136] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 221280: [build.webkit.org] Update dashboard links for layout test results
https://bugs.webkit.org/show_bug.cgi?id=221280

Attachment 419136: Patch

https://bugs.webkit.org/attachment.cgi?id=419136&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 419136
  --> https://bugs.webkit.org/attachment.cgi?id=419136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419136&action=review

>>
Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:200
>> +		url = this.baseURLForResults;
> 
> This doesn't look right. `options && options.baseURLForResults` should
resolve to a boolean

Ok, I see what we're doing here, but I'm not sure this is the clearest way to
express this. Can we change `this.baseURLForResults = options &&
options.baseURLForResults` to `this.baseURLForResults = options ?
options.baseURLForResults : null`