[webkit-reviews] review granted: [Bug 221350] [macOS] Selecting a date on datetime-local inputs unexpectedly adds second and millisecond fields : [Attachment 419170] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 221350: [macOS] Selecting a date on datetime-local inputs unexpectedly adds
second and millisecond fields
https://bugs.webkit.org/show_bug.cgi?id=221350

Attachment 419170: Patch

https://bugs.webkit.org/attachment.cgi?id=419170&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 419170
  --> https://bugs.webkit.org/attachment.cgi?id=419170
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419170&action=review

r=me, nice patch!

> Source/WebCore/html/BaseDateAndTimeInputType.cpp:548
> +    auto date = parseToDateComponents(element.value());
> +    if (date) {

rather than have an `else` could you
`parseToDateComponents(element.value()).valueOr({ })`?

> Source/WebCore/platform/DateTimeChooserParameters.h:54
>      bool required;
>      bool isAnchorElementRTL;
>      bool useDarkAppearance;
> +    bool hasSecondField;
> +    bool hasMillisecondField;

I wonder if all of these should have a default value `{ false }` (or `{ 0 }`
for the `double`s) or something ��