[webkit-reviews] review denied: [Bug 221304] Null Ptr Deref @ libWebCoreTestSupport.dylib: WebCoreTestSupport::resetInternalsObject : [Attachment 419076] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 221304: Null Ptr Deref @ libWebCoreTestSupport.dylib:
WebCoreTestSupport::resetInternalsObject
https://bugs.webkit.org/show_bug.cgi?id=221304

Attachment 419076: Patch

https://bugs.webkit.org/attachment.cgi?id=419076&action=review




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 419076
  --> https://bugs.webkit.org/attachment.cgi?id=419076
Patch

I'll say r- based on the previous conversation. I think that we need to get to
the bottom of this, as silencing the crash with a null check will be more
costly in terms of manual work analyzing failures than hitting crashes is.