[webkit-reviews] review denied: [Bug 221254] Some more Tools/wpe/install-dependencies missing : [Attachment 418985] proposed patch for Tools dependencies
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 3 04:52:38 PST 2021
Adrian Perez <aperez at igalia.com> has denied review:
Bug 221254: Some more Tools/wpe/install-dependencies missing
https://bugs.webkit.org/show_bug.cgi?id=221254
Attachment 418985: proposed patch for Tools dependencies
https://bugs.webkit.org/attachment.cgi?id=418985&action=review
--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 418985
--> https://bugs.webkit.org/attachment.cgi?id=418985
proposed patch for Tools dependencies
Patch looks fine, but you need to edit the ChangeLog before we can
accept it. The “webkit-patch” script (or “prepare-ChangeLog”) can
check your local changes and generate a skeleton of the edits in
the ChangeLog that then you can fill in.
There is a walkthrough here:
https://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit
Feel free to ask if you get stuck :)
More information about the webkit-reviews
mailing list