[webkit-reviews] review granted: [Bug 220977] Support aspect-ratio on grid items : [Attachment 419114] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 3 03:22:39 PST 2021
Javier Fernandez <jfernandez at igalia.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 220977: Support aspect-ratio on grid items
https://bugs.webkit.org/show_bug.cgi?id=220977
Attachment 419114: Patch
https://bugs.webkit.org/attachment.cgi?id=419114&action=review
--- Comment #11 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 419114
--> https://bugs.webkit.org/attachment.cgi?id=419114
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=419114&action=review
r=me
> Source/WebCore/rendering/RenderGrid.cpp:1866
> + // A non-auto inline size means the same for block size
Nit: no need to wrap comments here
> Source/WebCore/rendering/RenderGrid.cpp:1883
> + // A non-auto block size means the same for inline size
Ditto
More information about the webkit-reviews
mailing list