[webkit-reviews] review granted: [Bug 219194] the nested grid container which has replaced item with 'max-height' has wrong width(0px). : [Attachment 419000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 12:37:28 PST 2021


Javier Fernandez <jfernandez at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 219194: the nested grid container which has replaced item with 'max-height'
has wrong width(0px).
https://bugs.webkit.org/show_bug.cgi?id=219194

Attachment 419000: Patch

https://bugs.webkit.org/attachment.cgi?id=419000&action=review




--- Comment #3 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 419000
  --> https://bugs.webkit.org/attachment.cgi?id=419000
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419000&action=review

r=me

The failures doesn't seem related to this change, but please, try to verify it
before landing; especially the flexbox test.

> Source/WebCore/rendering/RenderReplaced.cpp:797
> +    // If the height is a percentage and the width is auto, then the

We usually avoid wrapping comments, unless they are too long.


More information about the webkit-reviews mailing list