[webkit-reviews] review granted: [Bug 221238] Completion value of a finally block should not be ignored if completion is abrupt : [Attachment 418953] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 221238: Completion value of a finally block should not be ignored if
completion is abrupt
https://bugs.webkit.org/show_bug.cgi?id=221238

Attachment 418953: Patch

https://bugs.webkit.org/attachment.cgi?id=418953&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 418953
  --> https://bugs.webkit.org/attachment.cgi?id=418953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418953&action=review

r=me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4560
> +	       int finallyStartOffset = m_catchBlock ?
m_catchBlock->endOffset() + 1 : m_tryBlock->endOffset() + 1;

Let's put this before this if-else.