[webkit-reviews] review granted: [Bug 220919] MachSemaphore does not work well with IPC messages : [Attachment 418992] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Kimmo Kinnunen <kkinnunen at apple.com>'s
request for review:
Bug 220919: MachSemaphore does not work well with IPC messages
https://bugs.webkit.org/show_bug.cgi?id=220919

Attachment 418992: Patch

https://bugs.webkit.org/attachment.cgi?id=418992&action=review




--- Comment #25 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 418992
  --> https://bugs.webkit.org/attachment.cgi?id=418992
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418992&action=review

> Source/WebKit/Platform/IPC/Semaphore.h:2
> + * Copyright (C) 2020 Apple Inc. All rights reserved.

Should be 2021!

> Source/WebKit/Platform/IPC/Semaphore.h:32
> +#if PLATFORM(COCOA)

I think I would use OS(DARWIN) here instead, as these are really OS level
concepts.

> Source/WebKit/Platform/IPC/Semaphore.h:40
> +namespace IPC {
> +class Decoder;
> +class Encoder;
> +class Semaphore {

This should have some newlines after the "namespace IPC {" and before "class
Semaphore {".

> Source/WebKit/Platform/IPC/Semaphore.h:48
> +    Semaphore& operator=(Semaphore&&);
> +    void encode(Encoder&) const;

We usually put a newline between these sections.

> Source/WebKit/Platform/IPC/Semaphore.h:51
> +#if PLATFORM(COCOA)

I think I would use OS(DARWIN) here instead.

> Source/WebKit/Platform/IPC/Semaphore.h:63
> +#if PLATFORM(COCOA)

I think I would use OS(DARWIN) here instead.