[webkit-reviews] review granted: [Bug 220951] REGRESSION(r269309): [Cocoa] RemoteInspectorCocoa files are being compiled twice : [Attachment 419021] Patch v1.1 (w/ Xcode project changes)

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted  review:
Bug 220951: REGRESSION(r269309): [Cocoa] RemoteInspectorCocoa files are being
compiled twice
https://bugs.webkit.org/show_bug.cgi?id=220951

Attachment 419021: Patch v1.1 (w/ Xcode project changes)

https://bugs.webkit.org/attachment.cgi?id=419021&action=review




--- Comment #12 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 419021
  --> https://bugs.webkit.org/attachment.cgi?id=419021
Patch v1.1 (w/ Xcode project changes)

View in context: https://bugs.webkit.org/attachment.cgi?id=419021&action=review

r=me with nit

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:4338
> +		99A3273725C9CBEE00DA8CAF /* Cocoa.cmake */ = {isa =
PBXFileReference; lastKnownFileType = text; path = Cocoa.cmake; sourceTree =
"<group>"; };

You shouldn't need to add the .cmake to the xcode

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:8776
> +				99A3273725C9CBEE00DA8CAF /* Cocoa.cmake */,

Ditto