[webkit-reviews] review granted: [Bug 221195] http/wpt/mediarecorder/mute-tracks.html is flaky : [Attachment 418846] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 221195: http/wpt/mediarecorder/mute-tracks.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=221195

Attachment 418846: Patch

https://bugs.webkit.org/attachment.cgi?id=418846&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 418846
  --> https://bugs.webkit.org/attachment.cgi?id=418846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418846&action=review

> LayoutTests/http/wpt/mediarecorder/mute-tracks.html:91
> -    var context = new AudioContext();
> +    let context = new AudioContext();
> +    let analyser = setupAudioContext(context, streamOrVideo);
>      for (var cptr = 0; cptr < 20; cptr++) {
> -	   var results = await analyseAudio(streamOrVideo, 200, context);
> -	   if (results.heardHum === expected)
> +	   var results = await analyseAudio(analyser, 200, context);

Nit: it is inconsistent to change only some of the `var` declarations to `let`.