[webkit-reviews] review granted: [Bug 221094] [macOS] Regression(r271897) Prewarmed WebProcesses no longer get a user-friendly process name in Activity Monitor : [Attachment 418933] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 221094: [macOS] Regression(r271897) Prewarmed WebProcesses no longer get a
user-friendly process name in Activity Monitor
https://bugs.webkit.org/show_bug.cgi?id=221094

Attachment 418933: Patch

https://bugs.webkit.org/attachment.cgi?id=418933&action=review




--- Comment #9 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 418933
  --> https://bugs.webkit.org/attachment.cgi?id=418933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418933&action=review

Thanks! R=me.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:482
> +	  
ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionT
oWebProcess::UpdateActivePages(displayName, Vector<String>(), auditToken), 0);

Is it sufficient to only call ensureNetworkProcessConnection().send here?

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:769
> +   
ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionT
oWebProcess::UpdateActivePages(overrideDisplayName,
activePagesOrigins(m_pageMap), auditToken), 0);

Ditto.