[webkit-reviews] review granted: [Bug 184886] WebAssembly: add support for stream APIs - JavaScript API: Implement loading for the Blob type : [Attachment 418968] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 184886: WebAssembly: add support for stream APIs - JavaScript API:
Implement loading for the Blob type
https://bugs.webkit.org/show_bug.cgi?id=184886

Attachment 418968: Patch

https://bugs.webkit.org/attachment.cgi?id=418968&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 418968
  --> https://bugs.webkit.org/attachment.cgi?id=418968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418968&action=review

> Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:349
> +    }

Sounds good like this.
Or maybe we could introduce a utility method that would handle blob through
consumeBodyReceivedByChunk, since the same thing is used in DOMCache.

>
LayoutTests/imported/w3c/web-platform-tests/wasm/wasm_stream_instantiate_test.h
tml:113
> +  }, "instantiateStreaming using blob");

Might be worth adding a test with form data even though we fail it for now?