[webkit-reviews] review granted: [Bug 214634] REGRESSION: Fullscreen HTML5 video subtitles/captions are shown twice : [Attachment 418917] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 214634: REGRESSION: Fullscreen HTML5 video subtitles/captions are shown
twice
https://bugs.webkit.org/show_bug.cgi?id=214634

Attachment 418917: Patch

https://bugs.webkit.org/attachment.cgi?id=418917&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 418917
  --> https://bugs.webkit.org/attachment.cgi?id=418917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418917&action=review

> Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:302
> +    m_needsGenerateTextTrackRepresentation = true;

I know this isn't new to this change, but
"m_needsToGenerateTextTrackRepresentation" would be a better name.