[webkit-reviews] review granted: [Bug 221125] [WebAuthn] Optimize _WKWebAuthenticationPanelDelegate for native API : [Attachment 418809] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 221125: [WebAuthn] Optimize _WKWebAuthenticationPanelDelegate for native
API
https://bugs.webkit.org/show_bug.cgi?id=221125

Attachment 418809: Patch

https://bugs.webkit.org/attachment.cgi?id=418809&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 418809
  --> https://bugs.webkit.org/attachment.cgi?id=418809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418809&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:509
> +    RunLoop::main().dispatch([weakPanel, call = WTFMove(call)] () {

Should we WTFMove() the weakPanel? We don't use it again outside the dispatch.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:155
> +	   [responses[0] setLAContext:laContext.get()];

Why not responses.firstObject?