[webkit-reviews] review granted: [Bug 220987] Web Inspector: move Box Model into Layout panel : [Attachment 418920] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 1 14:51:00 PST 2021
BJ Burg <bburg at apple.com> has granted Nikita Vasilyev <nvasilyev at apple.com>'s
request for review:
Bug 220987: Web Inspector: move Box Model into Layout panel
https://bugs.webkit.org/show_bug.cgi?id=220987
Attachment 418920: Patch
https://bugs.webkit.org/attachment.cgi?id=418920&action=review
--- Comment #3 from BJ Burg <bburg at apple.com> ---
Comment on attachment 418920
--> https://bugs.webkit.org/attachment.cgi?id=418920
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=418920&action=review
r=me with some little things
> Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:43
> + return hasDOMNode;
Nit: I prefer `return false`, it's easier to understand without any context.
> Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:91
> // FIXME: Move the Box Model section here from the Computed panel.
Nit: remove the FIXME
> Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:106
> // Private
I believe this needs to be ported over as well:
get minimumWidth()
{
return this._boxModelDiagramRow?.minimumWidth ?? 0;
}
More information about the webkit-reviews
mailing list