[webkit-reviews] review granted: [Bug 219325] [WPE][GTK] flatpak-spawn subsandbox clears environment variables, breaks EphyPermissionsManager : [Attachment 418876] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 219325: [WPE][GTK] flatpak-spawn subsandbox clears environment variables,
breaks EphyPermissionsManager
https://bugs.webkit.org/show_bug.cgi?id=219325

Attachment 418876: Patch

https://bugs.webkit.org/attachment.cgi?id=418876&action=review




--- Comment #12 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 418876
  --> https://bugs.webkit.org/attachment.cgi?id=418876
Patch

Patch idea LGTM, but please fix the issue below before landing :]


View in context: https://bugs.webkit.org/attachment.cgi?id=418876&action=review

> Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.cpp:72
> +	   GUniquePtr<char> quotedVariable(g_shell_quote(*variable));

Quoting the variable here is wrong because g_subprocess_launcher_spawnv()
below will result in the executable being invoked directly *without* the
shell intervening — either through a call to posix_spawn(), or a
fork()+execv*()
combo inside GLib.