[webkit-reviews] review granted: [Bug 190800] [JSC] Implement BigInt64Array and BigUint64Array : [Attachment 418821] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 190800: [JSC] Implement BigInt64Array and BigUint64Array
https://bugs.webkit.org/show_bug.cgi?id=190800

Attachment 418821: Patch

https://bugs.webkit.org/attachment.cgi?id=418821&action=review




--- Comment #12 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 418821
  --> https://bugs.webkit.org/attachment.cgi?id=418821
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418821&action=review

r=me, this is awesome!

> Source/JavaScriptCore/runtime/AtomicsObject.h:65
> +JSArrayBufferView* validateTypedArray(JSGlobalObject*, JSValue);

This seems kind of weird? AtomicsObject.cpp needs to include
JSArrayBufferView.h anyway, doesn't it?

> Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:98
> +    using Adaptor = PassedAdaptor;

What's the purpose of this alias?

> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:462
> +    if constexpr (Adaptor::canConvertToJSQuickly)

Cool!

> JSTests/test262/expectations.yaml:831
>
+test/built-ins/TypedArray/prototype/filter/BigInt/callbackfn-detachbuffer.js:
> +  default: 'TypeError: Invalid argument type in ToBigInt operation (Testing
with BigInt64Array.)'
> +  strict mode: 'TypeError: Invalid argument type in ToBigInt operation
(Testing with BigInt64Array.)'
>
+test/built-ins/TypedArray/prototype/findIndex/BigInt/predicate-may-detach-buff
er.js:
> +  default: 'Test262Error: throws a TypeError getting a value from the
detached buffer Expected a TypeError to be thrown but no exception was thrown
at all (Testing with BigInt64Array.)'
> +  strict mode: 'Test262Error: throws a TypeError getting a value from the
detached buffer Expected a TypeError to be thrown but no exception was thrown
at all (Testing with BigInt64Array.)'

Do you want to submit the patch for these or would you prefer that I do it?