[webkit-reviews] review granted: [Bug 221200] Only update IPC connection of RemoteCaptureSampleManager for audio sources : [Attachment 418861] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 221200: Only update IPC connection of RemoteCaptureSampleManager for audio
sources
https://bugs.webkit.org/show_bug.cgi?id=221200

Attachment 418861: Patch

https://bugs.webkit.org/attachment.cgi?id=418861&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 418861
  --> https://bugs.webkit.org/attachment.cgi?id=418861
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201
>  void
UserMediaCaptureManager::didUpdateSourceConnection(RemoteRealtimeMediaSource&
source)
>  {
> -    m_remoteCaptureSampleManager.didUpdateSourceConnection(source);
> +    if (source.type() == RealtimeMediaSource::Type::Audio)
> +	   m_remoteCaptureSampleManager.didUpdateSourceConnection(source);
>  }

It isn't clear why this should be for audio only. Should the method be renamed,
or at least add a comment explaining why this is?