[webkit-reviews] review granted: [Bug 221206] [SOUP] Stop using SoupBuffer in preparation for libsoup3 : [Attachment 418874] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 08:03:18 PST 2021


Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 221206: [SOUP] Stop using SoupBuffer in preparation for libsoup3
https://bugs.webkit.org/show_bug.cgi?id=221206

Attachment 418874: Patch

https://bugs.webkit.org/attachment.cgi?id=418874&action=review




--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 418874
  --> https://bugs.webkit.org/attachment.cgi?id=418874
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418874&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69
> +	   SoupBuffer* soupBuffer =
soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr),

auto* soupBuffer ?

Also I guess this would be migrated later right? Consider adding a comment.


More information about the webkit-reviews mailing list