[webkit-reviews] review granted: [Bug 219160] [GTK][WPE] Migrate WebKitTestServer to libsoup 2.48 API : [Attachment 418858] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 219160: [GTK][WPE] Migrate WebKitTestServer to libsoup 2.48 API
https://bugs.webkit.org/show_bug.cgi?id=219160

Attachment 418858: Patch

https://bugs.webkit.org/attachment.cgi?id=418858&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 418858
  --> https://bugs.webkit.org/attachment.cgi?id=418858
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418858&action=review

> Tools/TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:35
> +    m_soupServer = adoptGRef(soup_server_new("server-header",
"WebKitTestServer ", nullptr));

If options[ServerRunInThread] is set, I would go even further and create this
on the WorkQueue thread using your trick with BinarySemaphore to dispatch a
function and wait until it completes. Sharing m_soupServer across threads like
the current code does might work in practice, but I doubt it's safe.