[webkit-reviews] review granted: [Bug 234747] Updating the file name of attachment-backed images should automatically set the `alt` attribute : [Attachment 448082] For EWS

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 234747: Updating the file name of attachment-backed images should
automatically set the `alt` attribute
https://bugs.webkit.org/show_bug.cgi?id=234747

Attachment 448082: For EWS

https://bugs.webkit.org/attachment.cgi?id=448082&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 448082
  --> https://bugs.webkit.org/attachment.cgi?id=448082
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=448082&action=review

> Source/WebCore/html/HTMLAttachmentElement.h:67
> +    RefPtr<HTMLImageElement> enclosingImageElement() const;

Someone has to write down our rules about RefPtr vs. raw pointer in new code.
It seems clear this should be RefPtr in case we call any function using it as a
this pointer, but not sure where we wrote that down.