[webkit-reviews] review canceled: [Bug 234543] Archived subresource loads fail if m_allowedNetworkHosts doesn't include the remote URL : [Attachment 447896] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has canceled Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 234543: Archived subresource loads fail if m_allowedNetworkHosts doesn't
include the remote URL
https://bugs.webkit.org/show_bug.cgi?id=234543

Attachment 447896: Patch

https://bugs.webkit.org/attachment.cgi?id=447896&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 447896
  --> https://bugs.webkit.org/attachment.cgi?id=447896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447896&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:311
> +	       RunLoop::main().dispatch([resourceLoader = Ref { resourceLoader
}] {
> +		   resourceLoader->didFail(resourceLoader->blockedError());

This changed to call didFail on another run loop iteration to make this behave
more like a real load that was blocked and make the other existing tests pass.

> Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:116
> +	       if (!page->allowsLoadFromURL(proposedRequest.url(),
mainFrameMainResource))

I added this to prevent an allowed host from redirecting to a forbidden host. 
ResourceLoadNotifier::dispatchWillSendRequest was called when redirecting and
when preparing to send the initial request, so after moving it we need to do
this in two places.