[webkit-reviews] review granted: [Bug 234569] Don't create LocalStorage database for read if it does not exist : [Attachment 447734] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 234569: Don't create LocalStorage database for read if it does not exist
https://bugs.webkit.org/show_bug.cgi?id=234569

Attachment 447734: Patch

https://bugs.webkit.org/attachment.cgi?id=447734&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 447734
  --> https://bugs.webkit.org/attachment.cgi?id=447734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447734&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm:35
> +static NSString *expectedMessage;

Add an ivar to LocalStorageUIDelegate instead of a new static global, which
I've been working to remove in TestWebKitAPI.
[[LocalStorageUIDelegate alloc] initWithExpectedMessage:@"testValue"]