[webkit-reviews] review granted: [Bug 234627] Re-enable WebPushD.HandleInjectedPush API test : [Attachment 447851] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 21:03:56 PST 2021

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 234627: Re-enable WebPushD.HandleInjectedPush API test

Attachment 447851: Patch


--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 447851
  --> https://bugs.webkit.org/attachment.cgi?id=447851

View in context: https://bugs.webkit.org/attachment.cgi?id=447851&action=review

> Source/WebKit/webpushd/PushClientConnection.mm:83
> +	   // This isn't great, but currently the only user of webpushd in open
source builds is TestWebKitAPI and codeSigningIdentifier returns the null
String on x86_64 Macs.

Is this comment accurate? Are AppleSilicon Macs really different?

If so, the difference isn't reflected in this code.

More information about the webkit-reviews mailing list