[webkit-reviews] review granted: [Bug 234543] Archived subresource loads fail if m_allowedNetworkHosts doesn't include the remote URL : [Attachment 447837] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 16:37:59 PST 2021


Alex Christensen <achristensen at apple.com> has granted Matt Woodrow
<m_woodrow at apple.com>'s request for review:
Bug 234543: Archived subresource loads fail if m_allowedNetworkHosts doesn't
include the remote URL
https://bugs.webkit.org/show_bug.cgi?id=234543

Attachment 447837: Patch

https://bugs.webkit.org/attachment.cgi?id=447837&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 447837
  --> https://bugs.webkit.org/attachment.cgi?id=447837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447837&action=review

nicer

> Tools/TestWebKitAPI/Tests/mac/LoadWebArchive.mm:259
> +    NSData *data = [NSPropertyListSerialization dataFromPropertyList:archive
format:NSPropertyListBinaryFormat_v1_0 errorDescription:nil];

This is all duplicate code with the test before it.  Could we instead share it
and make a static function that returns an NSData?


More information about the webkit-reviews mailing list