[webkit-reviews] review denied: [Bug 234612] [Flatpak] Fix a11y tests on some distros including Fedora : [Attachment 447824] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 22 12:27:06 PST 2021
Michael Catanzaro <mcatanzaro at gnome.org> has denied Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 234612: [Flatpak] Fix a11y tests on some distros including Fedora
https://bugs.webkit.org/show_bug.cgi?id=234612
Attachment 447824: Patch
https://bugs.webkit.org/attachment.cgi?id=447824&action=review
--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 447824
--> https://bugs.webkit.org/attachment.cgi?id=447824
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=447824&action=review
> Tools/ChangeLog:10
> + On Debian the tests previously worked because the a11y bus is set
> + to a filesystem path (unix:abstract=/tmp/dbus-YvSOaUDNJe) however
> + on Fedora it is not a path (unix:abstract=00008). Using
--no-a11y-bus fixes this.
Something's wrong with this changelog explanation.
unix:abstract=/tmp/dbus-YvSOaUDNJe is not a filesystem path. It's a D-Bus
address that corresponds to an abstract socket with a name that *looks* like a
filesystem path, but of course abstract sockets definitionally do not exist on
the filesystem. Right? So what's *really* the difference between using that vs.
unix:abstract=00008?
(To access an abstract socket on the host, we would need to use --allow=net to
get the host network namespace.)
> Tools/flatpak/flatpakutils.py:767
> + # at-spi-registryd creates directories like
`$XDG_RUNTIME_DIR/at-spi2-E6A5E1` on the host
> + "--filesystem=" + GLib.get_user_runtime_dir(),
But there is --filesystem=host just above, so surely this is not needed?
More information about the webkit-reviews
mailing list