[webkit-reviews] review denied: [Bug 234578] Grid may be empty in certain scenarios : [Attachment 447760] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 22 02:36:41 PST 2021
Sergio Villar Senin <svillar at igalia.com> has denied Brandon
<brandonstewart at apple.com>'s request for review:
Bug 234578: Grid may be empty in certain scenarios
https://bugs.webkit.org/show_bug.cgi?id=234578
Attachment 447760: Patch
https://bugs.webkit.org/attachment.cgi?id=447760&action=review
--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 447760
--> https://bugs.webkit.org/attachment.cgi?id=447760
Patch
This is not correct as this should never happen. If there are no grid items
then we cannot have items in the asepectRatioBlockSizeDependentGridItems
Vector. If you're hitting this scenario then we are not properly handling some
weird scenario. You have to look for the root of the cause.
More information about the webkit-reviews
mailing list