[webkit-reviews] review granted: [Bug 234565] PCM tests crashing with 'unlink' errors : [Attachment 447737] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 21 14:44:12 PST 2021
Alex Christensen <achristensen at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 234565: PCM tests crashing with 'unlink' errors
https://bugs.webkit.org/show_bug.cgi?id=234565
Attachment 447737: Patch
https://bugs.webkit.org/attachment.cgi?id=447737&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 447737
--> https://bugs.webkit.org/attachment.cgi?id=447737
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=447737&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:323
> + EXPECT_FALSE([defaultFileManager fileExistsAtPath:itpRoot]);
This isn't necessary. If we exited the while loop, we know it is false.
More information about the webkit-reviews
mailing list